Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RESTError to restapi.go #1130

Merged
merged 1 commit into from Mar 13, 2022
Merged

Move RESTError to restapi.go #1130

merged 1 commit into from Mar 13, 2022

Conversation

switchupcb
Copy link
Contributor

The library has no packages, so it's easier to keep everything related to it's functionality. types.go only contains (error) functionality related to the the REST API, but it's not placed in restapi.go. Whereas wsapi.go errors remain in wsapi.go functionality. The latter is already implemented, so this pull request simply enforces that organization structure.

Also discussed: #1114

@FedorLap2006
Copy link
Collaborator

Thanks for your contribution!

@FedorLap2006 FedorLap2006 changed the title move REST-specific errors to REST API Move RESTError to restapi.go Mar 13, 2022
@FedorLap2006 FedorLap2006 merged commit 12edb3b into bwmarrin:master Mar 13, 2022
@switchupcb switchupcb deleted the consistency branch March 23, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants